-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Strip HTTP/2 pseudo headers from dev server requests #12830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When HTTPS is enabled, the dev server switches to HTTP/2. This creates H2 psuedo-headers in the request that are currently incompatible with unidici's parsing. This strips out those headers, with special handling for :authority (see RFC 9113: https://www.rfc-editor.org/rfc/rfc9113.html#section-8.3.1-2.3.5). Fixes #12558
🦋 Changeset detectedLatest commit: 051e1d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@brophdawg11 Can we get this merged in for the next release? |
@brophdawg11 Any chance we can get this in for 7.2.0? |
Ugh, sorry I missed this mention. Between paternity leave late last year and then the holiday break my github notifications are still a mess so I'm not catching these types of mentions. @brookslybrand just called my attention to this and it won't make it into 7.2 but I will look at it right after and we can get into |
🤖 Hello there, We just published version Thanks! |
When HTTPS is enabled, the dev server switches to HTTP/2. This creates H2 psuedo-headers in the request that are currently incompatible with unidici's parsing. This strips out those headers, with special handling for :authority (see RFC 9113: https://www.rfc-editor.org/rfc/rfc9113.html#section-8.3.1-2.3.5).
Fixes #12558